New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(npm): update rxjs to 2.0.0-beta.6 #8047
Conversation
I think I need to fix a couple of typings in |
c6c2e70
to
49eaf40
Compare
There are obscure Travis failures in environments I don't have time to troubleshoot right now, so please don't merge this unless someone can make it green. |
I'm going to try reproducing and fixing the Windows and Safari issues now |
@Blesh had the idea that our angular/modules/angular2/src/facade/lang.ts Line 454 in cc86fee
I changed that line to |
Got verbal LGTM from @alxhub @robertmesserle this will require updating internal version of Rx, which I can help with. It'd be great to get this landed before our next beta release. |
@jeffbcross going forward, if you need to access |
This is blocked on google internal ts1.9 upgrade. Will revisit after ng-conf. |
Just noticed this:
That would be a 3 major version downgrade. |
I'm going to rebase and get this thing ready for merge. We're not going to wait on G3. This is blocking some offline compiler work now. |
Thx @Blesh fixed commit message :) |
READY TO MERGE! |
Merging PR #8047 on behalf of @rkirov to branch presubmit-rkirov-pr-8047. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: this contains two commits from #8003 to make sure Travis will be green.