Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/linker): add SimpleChanges interface to lifecycle_hooks #8557

Closed
wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented May 9, 2016

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features) - none needed?
  • Docs have been added / updated (for bug fixes / features) - api docs should autoupdate; regular docs await approval of this change.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds the clarifying TypeScript interface, SimpleChanges
  • What is the current behavior? (You can also link to an open issue here)
    Many people, especially those new to TypeScript, are confused by the current type of the changes parameter - {[propName: string]: SimpleChange}. It's annoying to type and read even if you know immediately what it means. The SimpleChanges interface makes for a more compact and easy to understand syntax.
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Not a breaking change. Emits no code.
  • Other information:

@mhevery mhevery closed this in 0a872ff May 23, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 21, 2016
@wardbell wardbell deleted the add-simplechanges-type branch February 9, 2017 18:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants