Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(compiler): test schema generation only in Chrome #8581

Closed
wants to merge 1 commit into from
Closed

test(compiler): test schema generation only in Chrome #8581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 12 additions & 7 deletions modules/@angular/compiler/test/schema/dom_element_schema_registry_spec.ts
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@ import {
xit
} from '@angular/core/testing/testing_internal';

import {browserDetection} from '@angular/platform-browser/testing';

import {DomElementSchemaRegistry} from '@angular/compiler/src/schema/dom_element_schema_registry';
import {SecurityContext} from '../../core_private';
import {extractSchema} from './schema_extractor';
Expand Down Expand Up @@ -69,14 +71,17 @@ export function main() {
it('should detect properties on namespaced elements',
() => { expect(registry.hasProperty('@svg:g', 'id')).toBeTruthy(); });

it('generate a new schema', () => {
// console.log(JSON.stringify(registry.properties));
extractSchema(
if (browserDetection.isChromeDesktop) {
it('generate a new schema', () => {
// console.log(JSON.stringify(registry.properties));
extractSchema(
(descriptors) => {
// Uncomment this line to see:
// the generated schema which can then be pasted to the DomElementSchemaRegistry
// console.log(descriptors);
// Uncomment this line to see:
// the generated schema which can then be pasted to the DomElementSchemaRegistry
// console.log(descriptors);
});
});
});
}

});
}
46 changes: 31 additions & 15 deletions modules/@angular/platform-browser/test/browser_util_spec.ts
View file
Open in desktop
Expand Up @@ -16,7 +16,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: true
supportsIntlApi: true,
isChromeDesktop: true
},
{
name: 'Chrome mobile',
Expand All @@ -28,7 +29,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: true
supportsIntlApi: true,
isChromeDesktop: false
},
{
name: 'Firefox',
Expand All @@ -40,7 +42,8 @@ export function main() {
isWebkit: false,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'IE9',
Expand All @@ -52,7 +55,8 @@ export function main() {
isWebkit: false,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'IE10',
Expand All @@ -64,7 +68,8 @@ export function main() {
isWebkit: false,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'IE11',
Expand All @@ -76,7 +81,8 @@ export function main() {
isWebkit: false,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Edge',
Expand All @@ -88,7 +94,8 @@ export function main() {
isWebkit: false,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Android4.1',
Expand All @@ -100,7 +107,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Android4.2',
Expand All @@ -112,7 +120,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Android4.3',
Expand All @@ -124,7 +133,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Android4.4',
Expand All @@ -136,7 +146,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Safari7',
Expand All @@ -148,7 +159,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'Safari8',
Expand All @@ -160,7 +172,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'iOS7',
Expand All @@ -172,7 +185,8 @@ export function main() {
isWebkit: true,
isIOS7: true,
isSlow: true,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
},
{
name: 'iOS8',
Expand All @@ -184,7 +198,8 @@ export function main() {
isWebkit: true,
isIOS7: false,
isSlow: false,
supportsIntlApi: false
supportsIntlApi: false,
isChromeDesktop: false
}
];

Expand All @@ -199,6 +214,7 @@ export function main() {
expect(bd.isIOS7).toBe(StringMapWrapper.get(browser, 'isIOS7'));
expect(bd.isSlow).toBe(StringMapWrapper.get(browser, 'isSlow'));
expect(bd.supportsIntlApi).toBe(StringMapWrapper.get(browser, 'supportsIntlApi'));
expect(bd.isChromeDesktop).toBe(StringMapWrapper.get(browser, 'isChromeDesktop'));
});
});
});
Expand Down
4 changes: 4 additions & 0 deletions modules/@angular/platform-browser/testing/browser_util.ts
View file
Open in desktop
Expand Up @@ -43,6 +43,10 @@ export class BrowserDetection {
get supportsIntlApi(): boolean {
return this._ua.indexOf('Chrome/4') > -1 && this._ua.indexOf('Edge') == -1;
}

get isChromeDesktop(): boolean {
return this._ua.indexOf('Chrome') > -1 && this._ua.indexOf('Mobile Safari') == -1 && this._ua.indexOf('Edge') == -1;
}
}

export function dispatchEvent(element, eventType): void {
Expand Down