fix(compiler): Improved error reporting of the static reflector. #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,14 +177,12 @@ export class MetadataCollector { | |||
| // or | |||
| // var [<identifier>[, <identifier}+] = <expression>; | |||
| // are not supported. | |||
| let varValue = { | |||
| __symbolc: 'error', | |||
chuckjaz
added a commit
to chuckjaz/angular
that referenced
this pull request
Jun 4, 2016
StaticReflector provides more context on errors reported by the collector. The metadata collector now records the line and character of the node that caused it to report the error. Includes other minor fixes to error reporting and a wording change. Fixes angular#8978 Closes angular#9011
| @@ -390,7 +390,11 @@ export class StaticReflector implements ReflectorReader { | |||
| return context; | |||
| } | |||
| case "error": | |||
| throw new Error(expression['message']); | |||
| let message = expression['message']; | |||
| if (expression['line']) { | |||
There was a problem hiding this comment.
Could you add a test for showing line/column numbers?
tbosch
added
the
action: cleanup
chuckjaz
added a commit
to chuckjaz/angular
that referenced
this pull request
Jun 7, 2016
StaticReflector provides more context on errors reported by the collector. The metadata collector now records the line and character of the node that caused it to report the error. Includes other minor fixes to error reporting and a wording change. Fixes angular#8978 Closes angular#9011
chuckjaz
removed
the
action: cleanup
StaticReflector provides more context on errors reported by the collector. The metadata collector now records the line and character of the node that caused it to report the error. Includes other minor fixes to error reporting and a wording change. Fixes angular#8978 Closes angular#9011
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 10, 2016
StaticReflector provides more context on errors reported by the collector. The metadata collector now records the line and character of the node that caused it to report the error. Includes other minor fixes to error reporting and a wording change. Fixes angular#8978 Closes angular#9011
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 21, 2016
StaticReflector provides more context on errors reported by the collector. The metadata collector now records the line and character of the node that caused it to report the error. Includes other minor fixes to error reporting and a wording change. Fixes angular#8978 Closes angular#9011
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Errors generated by the
StaticReflectorused during offline compilation does not produce context to diagnose the reason the error occurred. E.g. #8978.What is the new behavior?
Improved the error message by including more information, including positional information and well as provide more context when the error message is generated.
Does this PR introduce a breaking change?
Other information:
StaticReflector provides more context on errors reported by the
collector.
The metadata collector now records the line and character of the node that
caused it to report the error.
Includes other minor fixes to error reporting and a wording change.