feat(compiler): introduce generated injectors #9053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| return this.getInjectorMetadata(someType, []); | ||
| } catch (e) { | ||
| if (e.message.indexOf('No InjectorConfig annotation') !== -1) { |
There was a problem hiding this comment.
should this be an instanceof test ? (add todo)
There was a problem hiding this comment.
No, we don't have a special error class here. Same as in maybeGetDirectiveMetadata...
There was a problem hiding this comment.
No, we don't have a special error class here
The question is should we ?
tbosch
force-pushed
the
gen_injector
branch
5 times, most recently
from
ccccd66
to
fd75b27
Compare
This commit is just adding them, but not using them yet for bootstrap. Related to angular#8997
| }); | ||
|
|
||
| it('should support property providers', | ||
| () => { var inj = SomeConfigInjectorFactory.create(null, new SomeConfig()); }); |
|
We won't do this for now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part that only adds features but does not use them yet.