fix(HTTP/XhrBackend): correctly set the status code on errors #9355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added
type: bug/fix
action: review
| @@ -181,14 +181,30 @@ export function main() { | |||
| existingXHRs[0].dispatchEvent('error'); | |||
| })); | |||
|
|
|||
| it('should set the status and status code on error', | |||
| }); | ||
| const xhr = existingXHRs[0]; | ||
| xhr.setStatusCode(0); | ||
| xhr.setStatusText(''); |
There was a problem hiding this comment.
please add a comment that status=0 and statusText='' are common values for CORS related errors. otherwise we'll wonder what these are.
There was a problem hiding this comment.
Not sure if we really care about the given values ? I'll add the comment anyway
|
please see comments above. otherwise lgtm |
|
thanks for tge review. I have addressed your comment and will merge. |
fixes angular#9329 fixes angular/http#54
hbkrunal
pushed a commit
to hbkrunal/angular
that referenced
this pull request
Sep 15, 2016
…r#9355) fixes angular#9329 fixes angular/http#54
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9329
fixes angular/http#54
@robwormald @jeffbcross could one of you please review ? Thanks