Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): allow empty CSS values. #9675

Merged
merged 1 commit into from Jun 28, 2016
Merged

fix(security): allow empty CSS values. #9675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/@angular/platform-browser/src/security/style_sanitizer.ts
View file
Open in desktop
Expand Up @@ -82,6 +82,7 @@ function hasBalancedQuotes(value: string) {
*/
export function sanitizeStyle(value: string): string {
value = String(value).trim(); // Make sure it's actually a string.
if (!value) return '';

// Single url(...) values are supported, but only for URLs that sanitize cleanly. See above for
// reasoning behind this.
Expand Down
1 change: 1 addition & 0 deletions modules/@angular/platform-browser/test/security/style_sanitizer_spec.ts
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@ export function main() {
function expectSanitize(v: string) { return t.expect(sanitizeStyle(v)); }

t.it('sanitizes values', () => {
expectSanitize('').toEqual('');
expectSanitize('abc').toEqual('abc');
expectSanitize('50px').toEqual('50px');
expectSanitize('rgb(255, 0, 0)').toEqual('rgb(255, 0, 0)');
Expand Down