-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): Adding global caches to survive/warn on HMR, cleanup, etc. (
#2661) * Adding global instance caches to the modules, so they don't freak out when HMR is enabled (#2655). This takes on `globalThis` as a needed polyfill for many environments. * If injected settings for modules are changed after they are initialized you will receive a warning and the prior instance will be returned (ignoring the changes), this is especially important for HMR. If HMR is detected there will be an additional warning suggesting they do a full reload to see the changes. * Added a polyfill table and notes about why we version like we do * Adding more convoluted stuff to my sample app to flex AngularFire * Internal cleanup on AngularFireAnalytics * AngularFireAnalytics will now wait for UserTrackingService to detect the user before sending the screen_view event, if UserTrackingService has been provided * Adding a warning if the Auth Emulator is detected in conjunction with AngularFirestore and AngularFireDatabase as they will invalidate the emulated auth token before the dynamic import of `firebase/auth` is completed (#2656) * Warn if we absorbed an error keeping Firestore persistence from enabling * Logging sign_up and login events in UserTrackingService * Adding credential observer to AngularFireAuth
- Loading branch information
1 parent
b00e14b
commit b666a80
Showing
25 changed files
with
501 additions
and
234 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
sample/src/app/firestore-offline/firestore-offline.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { waitForAsync, ComponentFixture, TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { FirestoreOfflineComponent } from './firestore-offline.component'; | ||
|
|
||
| describe('FirestoreComponent', () => { | ||
| let component: FirestoreOfflineComponent; | ||
| let fixture: ComponentFixture<FirestoreOfflineComponent>; | ||
|
|
||
| beforeEach(waitForAsync(() => { | ||
| TestBed.configureTestingModule({ | ||
| declarations: [ FirestoreOfflineComponent ] | ||
| }) | ||
| .compileComponents(); | ||
| })); | ||
|
|
||
| beforeEach(() => { | ||
| fixture = TestBed.createComponent(FirestoreOfflineComponent); | ||
| component = fixture.componentInstance; | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
| }); |
37 changes: 37 additions & 0 deletions
37
sample/src/app/firestore-offline/firestore-offline.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { Component, OnInit } from '@angular/core'; | ||
| import { AngularFirestore } from '@angular/fire/firestore'; | ||
| import { Observable } from 'rxjs'; | ||
| import { startWith, tap } from 'rxjs/operators'; | ||
| import { makeStateKey, TransferState } from '@angular/platform-browser'; | ||
| import { trace } from '@angular/fire/performance'; | ||
| import { AngularFirestoreOffline } from './firestore-offline.module'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-firestore-offline', | ||
| template: `<p> | ||
| Firestore Offline! | ||
| {{ testDocValue$ | async | json }} | ||
| {{ persistenceEnabled$ | async }} | ||
| </p>`, | ||
| styles: [``] | ||
| }) | ||
| export class FirestoreOfflineComponent implements OnInit { | ||
|
|
||
| public readonly persistenceEnabled$: Observable<boolean>; | ||
| public readonly testDocValue$: Observable<any>; | ||
|
|
||
| constructor(state: TransferState, firestore: AngularFirestoreOffline) { | ||
| const doc = firestore.doc('test/1'); | ||
| const key = makeStateKey(doc.ref.path); | ||
| const existing = state.get(key, undefined); | ||
| this.testDocValue$ = firestore.doc('test/1').valueChanges().pipe( | ||
| trace('firestore'), | ||
| existing ? startWith(existing) : tap(it => state.set(key, it)) | ||
| ); | ||
| this.persistenceEnabled$ = firestore.persistenceEnabled$; | ||
| } | ||
|
|
||
| ngOnInit(): void { | ||
| } | ||
|
|
||
| } |
28 changes: 28 additions & 0 deletions
28
sample/src/app/firestore-offline/firestore-offline.module.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { Inject, Injectable, InjectionToken, NgModule, NgZone, Optional, PLATFORM_ID } from '@angular/core'; | ||
| import { FirebaseOptions, FIREBASE_OPTIONS } from '@angular/fire'; | ||
| import { USE_EMULATOR } from '@angular/fire/firestore'; | ||
| import { AngularFirestore, SETTINGS, Settings } from '@angular/fire/firestore'; | ||
| import { USE_EMULATOR as USE_AUTH_EMULATOR } from '@angular/fire/auth'; | ||
|
|
||
| export const FIRESTORE_OFFLINE = new InjectionToken<AngularFirestore>('my.firestore'); | ||
|
|
||
| @Injectable() | ||
| export class AngularFirestoreOffline extends AngularFirestore { | ||
| constructor( | ||
| @Inject(FIREBASE_OPTIONS) options: FirebaseOptions, | ||
| @Optional() @Inject(SETTINGS) settings: Settings | null, | ||
| // tslint:disable-next-line:ban-types | ||
| @Inject(PLATFORM_ID) platformId: Object, | ||
| zone: NgZone, | ||
| @Optional() @Inject(USE_EMULATOR) useEmulator: any, | ||
| @Optional() @Inject(USE_AUTH_EMULATOR) useAuthEmulator: any, | ||
| ) { | ||
| super(options, 'offline', true, settings, platformId, zone, { synchronizeTabs: true }, useEmulator, useAuthEmulator); | ||
| } | ||
| } | ||
|
|
||
| @NgModule({ | ||
| providers: [ AngularFirestoreOffline ] | ||
| }) export class FirestoreOfflineModule { | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.