Adding the zone arg to the app factory

angular · Nov 12, 2019 · d7d52c8 · d7d52c8
1 parent 6638b9d
commit d7d52c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/analytics/analytics.ts b/src/analytics/analytics.ts
@@ -37,7 +37,7 @@ export class AngularFireAnalytics {
   ) {
     // @ts-ignore zapping in the UMD in the build script
     const requireAnalytics = from(import('firebase/analytics'));
-    const app = _firebaseAppFactory(options, nameOrConfig);
+    const app = _firebaseAppFactory(options, zone, nameOrConfig);
 
     this.analytics = requireAnalytics.pipe(
       map(() => app.analytics()),
@@ -63,7 +63,7 @@ export class AngularFireAnalytics {
           }
           if (automaticallySetCurrentScreen !== false) {
             // TODO when is screen_name undefined?
-            analytics.setCurrentScreen(screen_name || url, { global: outlet == "primary" })
+            analytics.setCurrentScreen(screen_name || url, { global: outlet == "primary" });
           }
         }),
         runOutsideAngular(zone)

diff --git a/src/remote-config/remote-config.ts b/src/remote-config/remote-config.ts
@@ -43,7 +43,7 @@ export class AngularFireRemoteConfig {
 
     this.remoteConfig = requireRemoteConfig.pipe(
       map(rc => rc.registerRemoteConfig(firebase)),
-      map(() => _firebaseAppFactory(options, nameOrConfig)),
+      map(() => _firebaseAppFactory(options, zone, nameOrConfig)),
       map(app => app.remoteConfig()),
       tap(rc => {
         if (settings) { rc.settings = settings }