Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank page renders with AngularFire 5.4.x #2314

Closed
anisabboud opened this issue Feb 5, 2020 · 10 comments
Closed

Blank page renders with AngularFire 5.4.x #2314

anisabboud opened this issue Feb 5, 2020 · 10 comments

Comments

@anisabboud
Copy link

  • 5.3.1 works fine for me with latest Angular 8.3.24 and Firebase 7.8.0.
  • When upgrading to 5.4.0 or 5.4.1, my angular app loads a blank page. There are no errors in the terminal/console (and logging auth state and user id is successful), but inspecting the page shows that the <app-root> element contains only an empty <router-outlet> and no other components were loaded...
  • Downgrading back to 5.3.1 works fine again...

Are there any breaking changes in 5.4.0 I should look for? Thanks!

@jamesdaniels
Copy link
Member

We did a lot of Zone.js work that landed in 5.4, that could be causing trouble. Hmmmm...

@jamesdaniels
Copy link
Member

I'd say stick with 5.3.1 for now. Are you planning on migrating to ng 9 once it's out? Curious if you'd run into this with AngularFire v6 too, as in theory I rebased all that in...

If you have an easy repro feel free to share, jamesdaniels@google.com

@jamesdaniels jamesdaniels changed the title Problem updating from 5.3.1 to 5.4.0 Blank page renders with AngularFire 5.4.x Feb 5, 2020
@sarunint
Copy link
Contributor

sarunint commented Feb 6, 2020

Might related to #2309

@jamesdaniels
Copy link
Member

Agreed. I'm taking the problematic share out and running the tests now.

@jamesdaniels
Copy link
Member

@anisabboud can you check 5.4.2?

@anisabboud
Copy link
Author

5.4.2 works well, thanks @jamesdaniels!

(Yes, I'm planning to upgrade to Angular 9 and AngularFire v6 once it's out.)

@jamesdaniels
Copy link
Member

Excellent. Don’t hesitate to reach out if you have any trouble with the RC.

@josejaner
Copy link

what is the latest stable version of firebase and angular that work well with 5.4.2?

  • AngularFire: 5.4.2
  • Firebase: ?
  • Angular: ?

@jamesdaniels
Copy link
Member

AngularFire 5.4 should work correctly with Angular 8 and any recent Firebase JS SDK version. See peerDependencies in published package.json

@josejaner
Copy link

latest stable version with angular 8
AngularFire: 5.4.2 Firebase: 7.10.0 Angular: 8.3.25

but with 9, is any already available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants