AngularFireAuth.authState does not fire

[sarunint]

Version info

Angular: 8.2.14

Firebase: 7.8.0

AngularFire: 5.4.0-5.4.1

Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

Failing test unit, Plunkr, or JSFiddle demonstrating the problem: https://stackblitz.com/edit/angular-lgfgbl

Steps to set up and reproduce

1. Fill your Firebase config in app.module.ts
2. Run
3. Click "Sign in with Google"

Sample data and security rules: none

Debug output

** Errors in the JavaScript console **: none

** Output from firebase.database().enableLogging(true); **: not applicable

** Screenshots **

Expected behavior

After redirected back from sign-in, you should be automatically to /main path.

Actual behavior

The app does not redirect you to /main path. (It does in @angular/fire@5.3.1.)

My observation

If I remove the line this.user$ = this.afa.authState; out from app.component.ts, it works! Doesn't know why.

[techn1fire]

Same issue here. Seems to fire randomly, or after a few seconds during testing.

[JoshuvaGeorge03]

I do having this issue, how to fix this?

[FlexWilliams]

Seeing same issue with the authState observable not being fired when subscribed to.

Just upgraded:
firebase 6.5.0 to 7.8.0
@angular/fire 5.2.1 to 5.4.0

[Benny739]

Same issue here.

[alexregier]

Same here :D

[jamesdaniels]

Should be addressed in 5.4.1, sorry for the regression. Please reopen if you're still having trouble after upgrading.

[sarunint]

It does not fix this 😉. That's the reason why this issue and #2307 are separated.

[sarunint]

@jamesdaniels It seems that I can't reopen this issue. Lol

[sarunint]

I've been able to create a simpler reproduction here: https://stackblitz.com/edit/angular-bk3qb6

[sarunint]

I've also noticed that changing to .user solves the problem.

But, if you change both .authState to .user, the problem still exists.

I think this is may be due to how both fields is constructed.

angularfire/src/auth/auth.ts

Lines 50 to 56 in 168077b

	this.authState = new Observable<User | null>(subscriber => {
	return zone.runOutsideAngular(() => this.auth.onAuthStateChanged(subscriber));
	}).pipe(keepUnstableUntilFirst);;
	this.user = new Observable<User | null>(subscriber => {
	return zone.runOutsideAngular(() => this.auth.onIdTokenChanged(subscriber));
	}).pipe(keepUnstableUntilFirst);

I'm thinking ReplaySubject might work here...

[jamesdaniels]

Just killed my last comment since I've found the root cause and I was going down the wrong path. It seems something about the new Zone refactors is breaking multiplexing.

[jamesdaniels]

It seems to be forcing a share, where one shouldn't exist, even if you use a different factory. This came up in review but I thought it was addressed.

[jamesdaniels]

Since it's shared without replay, the second subscribe gets no result until a change comes through; since it's not creating a new observable. If I don't have a fix quickly I'll revert the zone memory leaks in a patch. Thanks so much for catching this!

[jamesdaniels]

Demonstrating the break fix/here https://stackblitz.com/edit/angular-7kb1uf?file=src%2Fapp%2Fapp.component.ts

[JoshuvaGeorge03]

This issue still present in 5.4.1 also.

[jamesdaniels]

Fixed in 5.4.2

[FlexWilliams]

Updated to 5.4.2, looks fixed on my end, running:

"@angular/fire": "^5.4.2",
"firebase": "^7.8.0"

Thanks for the quick fix!

[ckrandhir]

I think it not working in "@angular/fire": "^6.0.0". Could you please look into this?