Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEFAULT_ from DEFAULT_FIREBASE and DEFAULT_FIREBASE_REF #25

Closed
jeffbcross opened this issue Jan 26, 2016 · 0 comments
Closed

Remove DEFAULT_ from DEFAULT_FIREBASE and DEFAULT_FIREBASE_REF #25

jeffbcross opened this issue Jan 26, 2016 · 0 comments
Assignees
@jeffbcross

Comments

@jeffbcross
Copy link
Contributor

The secondary multi-binding can say SECONDARY_, the primary one doesn't need to say default, since most of the time there will just be one Firebase.
@jeffbcross jeffbcross self-assigned this Jan 29, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jan 29, 2016
@jeffbcross
fix(providers): remove DEFAULT_ DEFAULT_FIREBASE_REF and DEFAULT_FIRE…
842f3cd 
…BASE

BREAKING CHANGE:
The tokens to inject the root firebase url and reference have changed from
DEFAULT_FIREBASE -> FirebaseUrl
DEFAULT_FIREBASE_REF -> FirebaseRef

Closes angular#25
@jeffbcross jeffbcross mentioned this issue Jan 29, 2016
Merged
@jeffbcross jeffbcross changed the title Remove DEFAULT_ from DEFAULT_FIREBASE and DEFAULT_FIREBASE_REF Remove DEFAULT_ from DEFAULT_FIREBASE and DEFAULT_FIREBASE_REF Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffbcross jeffbcross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffbcross