Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(FirebaseList): child_added needs to account for prevKey #26

Closed
jeffbcross opened this issue Jan 27, 2016 · 0 comments
Closed

bug(FirebaseList): child_added needs to account for prevKey #26

jeffbcross opened this issue Jan 27, 2016 · 0 comments
Assignees
@jeffbcross
Labels
comp: Firebase(List | Object) type: bug
Milestone
Usable alpha

Comments

@jeffbcross
Copy link
Contributor

Sometimes children are added with a key less than the end of the list, and so similar algorithm as child_moved should be applied.
@jeffbcross jeffbcross modified the milestone: alpha.5 Jan 29, 2016
@jeffbcross jeffbcross changed the title child_added needs to account for prevKey in FirebaseList bug(FirebaseList): child_added needs to account for prevKey Feb 2, 2016
@jeffbcross jeffbcross modified the milestones: alpha.5, Iteration 3 Feb 9, 2016
@jteplitz jteplitz self-assigned this Feb 18, 2016
@jeffbcross jeffbcross modified the milestone: Iteration 3 Mar 7, 2016
@jeffbcross jeffbcross assigned jeffbcross and unassigned jteplitz Mar 20, 2016
@jeffbcross jeffbcross added this to the Usable alpha milestone Mar 20, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Mar 20, 2016
@jeffbcross
fix(FirebaseListFactory): account for prevKey in child_added handler
c38a0db 
Previously, the prevKey would be ignored when processing child_added
event. All added children would be added to the end of the array,
which isn't always the case. Now, the child will be inserted at the
correct position in the array.

Closes angular#26
@jeffbcross jeffbcross mentioned this issue Mar 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffbcross jeffbcross

Labels
comp: Firebase(List | Object) type: bug
Projects
None yet
Milestone
Usable alpha
Development

No branches or pull requests
2 participants
@jteplitz @jeffbcross