Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FirebaseList): separate FirebaseListFactory into separate module #35

Closed
jeffbcross opened this issue Feb 2, 2016 · 0 comments
Closed

chore(FirebaseList): separate FirebaseListFactory into separate module #35

jeffbcross opened this issue Feb 2, 2016 · 0 comments
Assignees
@davideast
Labels
comp: Firebase(List | Object) type: chore
Milestone
alpha.5

Comments

@jeffbcross
Copy link
Contributor

The FirebaseListFactory function does the hard work of subscribing to a firebase path and providing a synchronized array to the user. Right now it lives inside providers/firebase_list. Since FirebaseListFactory will be used in different contexts (JS service and pipes, for example), it should be separated into its own file, such as utils/firebase_list_factory.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davideast davideast

Labels
comp: Firebase(List | Object) type: chore
Projects
None yet
Milestone
alpha.5
Development

No branches or pull requests
2 participants
@jeffbcross @davideast