Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FirebaseList): remove FirebaseList provider from library #46

Closed
jeffbcross opened this issue Feb 3, 2016 · 0 comments
Closed

chore(FirebaseList): remove FirebaseList provider from library #46

jeffbcross opened this issue Feb 3, 2016 · 0 comments
Labels
comp: providers type: chore
Milestone
Iteration 3

Comments

@jeffbcross
Copy link
Contributor

While functional, it's awkward to use, and is distracting from better paths to do the same thing.
@jeffbcross jeffbcross added this to the alpha.5 milestone Feb 3, 2016
@jeffbcross jeffbcross changed the title Remove FirebaseList provider from library chore(FirebaseList): remove FirebaseList provider from library Feb 3, 2016
@jeffbcross jeffbcross modified the milestones: alpha.5, Iteration 3 Feb 9, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Feb 16, 2016
@jeffbcross
fix(FirebaseList): remove FirebaseList from library
da6cb2f 
BREAKING CHANGE:

Before this change, it was possible to inject an observable of a synchronized
list into a component by calling FirebaseList to get a provider:

```
@component({providers: [FirebaseList('/questions')]})
class MyComponent {
  constructor(@Inject('/questions') questions) {}
}
```

This behavior has been replaced by the injectable AngularFire service:

```
@component({providers: [AngularFire]})
class MyComponent {
  constructor(af:AngularFire) {
    this.questions = af.list('/questions');
  }
}
```

Closes angular#46
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Feb 16, 2016
@jeffbcross
fix(FirebaseList): remove FirebaseList from library
2e8a2ec 
BREAKING CHANGE:

Before this change, it was possible to inject an observable of a synchronized
list into a component by calling FirebaseList to get a provider:

```
@component({providers: [FirebaseList('/questions')]})
class MyComponent {
  constructor(@Inject('/questions') questions) {}
}
```

This behavior has been replaced by the injectable AngularFire service:

```
@component({providers: [AngularFire]})
class MyComponent {
  constructor(af:AngularFire) {
    this.questions = af.list('/questions');
  }
}
```

Closes angular#46
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Feb 16, 2016
@jeffbcross
fix(FirebaseList): remove FirebaseList from library
4f6106c 
BREAKING CHANGE:

Before this change, it was possible to inject an observable of a synchronized
list into a component by calling FirebaseList to get a provider:

```
@component({providers: [FirebaseList('/questions')]})
class MyComponent {
  constructor(@Inject('/questions') questions) {}
}
```

This behavior has been replaced by the injectable AngularFire service:

```
@component({providers: [AngularFire]})
class MyComponent {
  constructor(af:AngularFire) {
    this.questions = af.list('/questions');
  }
}
```

Closes angular#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: providers type: chore
Projects
None yet
Milestone
Iteration 3
Development

No branches or pull requests
1 participant
@jeffbcross