Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default import for firebase #2079

Merged
merged 2 commits into from
May 21, 2019
Merged

fix: use default import for firebase #2079

merged 2 commits into from
May 21, 2019

Commits on May 21, 2019

  1. use default import for firebase

    @Feiyang1
    Feiyang1 committed May 21, 2019
    Configuration menu
    Copy the full SHA
    00dbfcf View commit details
    Browse the repository at this point in the history

  2. Fix for the ng6 production build test 

    We can't implicitly use the firestore type (i.e, the injection tokens) as typescript will compile this into a dynamic import in our d.ts & will break ng 6 users who are still on older versions.
    @jamesdaniels
    jamesdaniels committed May 21, 2019
    Configuration menu
    Copy the full SHA
    f86ccad View commit details
    Browse the repository at this point in the history