fix(analytics): removed providedIn: 'any' from the service injectable

[jackcw]

Checklist

• Issue number for this PR: screen_view events being auto logged regardless of ScreenTrackingService being provided #2604
• Docs included?: no
• Test units included?: no
• In a clean directory, yarn install, yarn test run successfully? yes

Description

The ScreenTrackingService and UserTrackingService would automatically be initialised even when not provided meaning you cant turn them off.

Code sample

Changed from

@Injectable({ providedIn: 'any' })

to

@Injectable()

[yasinkocak]

Should this not be a singleton?

@Injectable({
  providedIn: 'root'
})

[jackcw]

When i tried that @yasinkocak it triggers the screen_view event when its not provided. Only way to make it work that i saw was with removing providedIn all together

[jamesdaniels]

Interesting, so the theses modules aren't tree-shaking out even if you don't provide them... weird. Let me dig into this a bit and see if we can address in a patch. Thanks for the help :)

[jamesdaniels]

This looks like a good solution to me.