Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark compatibility with ng 15 peer #3291

Merged
merged 5 commits into from Nov 22, 2022
Merged

Mark compatibility with ng 15 peer #3291

merged 5 commits into from Nov 22, 2022

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 22, 2022

Fix #3290

We need to bump major soon and drop the older Angular versions, the matrix test is getting a bit difficult to manage w/so many variants.

  • Drop ng12 from the tests, JS SDK (typescript) broke, not work hunting for a good version IMO
  • Skip prerender test on ng13, broken not worth hunting the flake IMO
  • Add ng15 to the matrix, add upgrade to ng14 step
  • Bump the version
  • Add ng15 to the acceptable peers
  • Add to README
  • Contrib tests are failing on newer Node, we should look into but not block merging and cutting

@jamesdaniels jamesdaniels changed the title Marked as compatible with the ng15 peer Mark compatibility with ng 15 peer Nov 22, 2022
@jamesdaniels jamesdaniels merged commit 57d9005 into master Nov 22, 2022
@jamesdaniels jamesdaniels deleted the ng15 branch November 22, 2022 21:20
@Franciscogerman
Copy link

very good

@muhammadalizkhan
Copy link

Its Still Not Working, Facing Same Issue RightnOw

@muhammadalizkhan
Copy link

Interface 'QuerySnapshot' incorrectly extends interface 'QuerySnapshot'.
Types of property 'docs' are incompatible.
Type 'QueryDocumentSnapshot[]' is not assignable to type 'QueryDocumentSnapshot[]'.
Type 'QueryDocumentSnapshot' is not assignable to type 'QueryDocumentSnapshot'.
The types returned by 'data(...)' are incompatible between these types.
Type 'T' is not assignable to type 'DocumentData'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular v15 support
3 participants