Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): allow initializeApp to be used with AOT #1654

Merged
merged 1 commit into from May 15, 2018
Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 15, 2018

Checklist

Description

Turns out type guards cannot be used in decorators.

We'd like to keep AngularFireModule.initializeApp in step with the Firebase JS SDK's initializeApp, so I had to change the Injection Tokens yet again; fortunately these were not documented to begin with. Dropping FirebaseAppConfigToken and FirebaseAppNameToken in favor of a new FirebaseNameOrConfigToken.

This will allow AngularFireModule.initializeApp to be used with AOT, which we regressed on in RC.8.

@jamesdaniels
Copy link
Member Author

@codediodeio I think this is an alright solution, thoughts?

@codediodeio
Copy link
Contributor

@jamesdaniels That looks to me, best of both worlds. It fixed the error on my end.

Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit 513565a into master May 15, 2018
@davideast davideast deleted the initializeApp branch May 15, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants