fix: use default import for firebase #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
changed the title
|
Oh good catch @Feiyang1, I was too caught up in the browser errors to think about the Node.js typings issue. I'll tweak the PR a bit to figure out why the typings test is grumpy. Thanks! |
We can't implicitly use the firestore type (i.e, the injection tokens) as typescript will compile this into a dynamic import in our d.ts & will break ng 6 users who are still on older versions.
jamesdaniels
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to fix the Nodejs build -
firebase/firebase-js-sdk#1754 (comment)
#2071
The root cause is that firebase type definition is incompatible with the esm build. We will fix it in the next major version in firebase, but before that happens we will need this workaround.