Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(): Call out to Angular Universal #1816

Merged
merged 2 commits into from Aug 15, 2018
Merged

docs(): Call out to Angular Universal #1816

merged 2 commits into from Aug 15, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

davideast
davideast approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesdaniels jamesdaniels merged commit df68aa2 into master Aug 15, 2018
@jamesdaniels jamesdaniels deleted the ssr-callout branch August 15, 2018 20:49
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@jamesdaniels @sulco
docs(): Call out to Angular Universal (angular#1816)
6244895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesdaniels @davideast @googlebot