docs(universal): getting started, serving with Cloud Functions, and prerendering #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @codediodeio this is where I think I'm going with the Universal Docs, thoughts? |
davideast
requested changes
Aug 30, 2018
README.md
Outdated
| @@ -76,7 +76,7 @@ Firebase offers two cloud-based, client-accessible database solutions that suppo | |||
|
|
|||
| #### Realtime Database | |||
|
|
|||
| > `AngularFireDatabase` allows you to work with the Realtime Database, Firebase's original database. It's an efficient, low-latency solution for mobile apps that require synced states across clients in realtime. | |||
| > `AngularFireDatabase` allows you to work with the Realtime Database, Firebase's original database. It's an efficient, low-latency solution for mobile apps that require synced states across clients in real-time. | |||
There was a problem hiding this comment.
"realtime" over "real-time" this goes way back to the early Firebase days.
jamesdaniels
changed the title
|
@davideast addressed and flushed out more. |
davideast
approved these changes
Sep 11, 2018
docs/universal/getting-started.md
Outdated
| @@ -1,11 +1,11 @@ | |||
| # Server-side Rendering with Universal | |||
| # Getting started with Angularfire and Universal | |||
|
|
||
|
|
||
| ```js | ||
| const path = require('path'); | ||
| const webpack = require('webpack'); | ||
|
|
||
| const APP_NAME = 'YOUR_PROJECT_NAME'; | ||
| const APP_NAME = 'YOUR_PROJECT_NAME'; // TODO: replace me! |
There was a problem hiding this comment.
I think we need more context around 'YOUR_APP_NAME. Something comment like "This is the same as the folder name...".
There was a problem hiding this comment.
Better yet, my mid-term plan here is to read the paths from the angular.json file; need to fiddle there. SGTY?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Extracted code from jamesdaniels/AngularFireDocs.
Code sample