Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

bug: HTML in model attribute is rendered #135

Closed
henrik opened this issue Aug 19, 2014 · 3 comments
Closed

bug: HTML in model attribute is rendered #135

henrik opened this issue Aug 19, 2014 · 3 comments
Assignees
@SomeKittens
Labels
type: bug

Comments

@henrik
Copy link

henrik commented Aug 19, 2014

This has some YouTube embed HTML:

screenshot
@btford
Copy link
Contributor

btford commented Dec 10, 2014

Confirmed.

This is still an issue in some places in v0.5.0 in the batJsonTree.

@btford btford changed the title HTML in model attribute is rendered bug: HTML in model attribute is rendered Dec 11, 2014
@SomeKittens
Copy link
Member

Still an issue in latest
screen shot 2015-11-12 at 1 07 47 pm

JSBin for reproing: http://jsbin.com/fepisivoje/edit?html,js

@SomeKittens SomeKittens self-assigned this Nov 12, 2015
SomeKittens added a commit that referenced this issue Nov 12, 2015
@SomeKittens
fix(escaping): Escape key/value properties on scope
c221af5 
Previously, we weren't escaping HTML entities in scope key/vals.  This opens up a whole host of issues.
Instead, escape things before we drop them into our extension panel.

Closes #135
@SomeKittens SomeKittens mentioned this issue Nov 12, 2015
Closed
@henrik
Copy link
Author

henrik commented Dec 1, 2015

@SomeKittens 🎉 Awesome, good job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SomeKittens SomeKittens

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@henrik @btford @SomeKittens