Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bug deploy npm version "0.1.2" #11

Closed
Zizzamia opened this issue Sep 3, 2014 · 2 comments
Closed

Bug deploy npm version "0.1.2" #11

Zizzamia opened this issue Sep 3, 2014 · 2 comments

Comments

@Zizzamia
Copy link

Zizzamia commented Sep 3, 2014

I did few minutes ago
npm install -g angular-benchpress
and as result I got this

angular-benchpress@0.1.2 /[ My machine info ]/node_modules/angular-benchpress
├── rimraf@2.2.8
├── underscore@1.7.0
├── minimist@1.1.0
├── mkdirp@0.5.0 (minimist@0.0.8)
├── bootstrap@3.2.0
└── http-server@0.6.1 (opener@1.3.0, colors@0.6.2, portfinder@0.2.1, optimist@0.5.2, ecstatic@0.4.13, union@0.3.8)

As you can see the first thing notice it's that the package.json downlod this dependencies

"dependencies": {
    "bootstrap": "^3.2.0",
    "http-server": "^0.6.1",
    "minimist": "^1.1.0",
    "mkdirp": "^0.5.0",
    "rimraf": "^2.2.8",
    "underscore": "^1.6.0"
 }

instead

"dependencies": {
    "bootstrap": "^3.2.0",
    "express": "^4.8.6",
    "minimist": "^1.1.0",
    "mkdirp": "^0.5.0",
    "rimraf": "^2.2.8",
    "underscore": "^1.6.0"
}

The second weird thing is the file lib/cli.js on the line 87/90 load these lines

if (!benchmarks || !benchmarks.length) {
  throw new Error('No benchmark directories found in ' benchmarksPath);
}

As you can see this js error cause a bug during the benchpress build

$ benchpress build

[My machine]/node_modules/angular-benchpress/lib/cli.js:88
          throw new Error('No benchmark directories found in ' benchmarksPath)
                                                               ^^^^^^^^^^^^^^

I did double check your latest version of cli.js https://github.com/angular/benchpress/blob/master/lib/cli.js#L89 and it's totally different.

In the end I think the last npm publish did't work correcty with the latest version.
Maybe one cause could be you the missing github tag https://github.com/angular/benchpress/releases

I hope did explain correctly my issue :)
Ciao

@jeffbcross
Copy link
Contributor

@Zizzamia I just pushed a new version; does it fix the issue?

@Zizzamia
Copy link
Author

Zizzamia commented Sep 3, 2014

Yes 👍

$ sudo npm install -g angular-benchpress
....
angular-benchpress@0.1.3 [ My machine ]/node_modules/angular-benchpress
├── rimraf@2.2.8
├── underscore@1.7.0
├── minimist@1.1.0
├── mkdirp@0.5.0 (minimist@0.0.8)
├── express@4.8.7 (........)
└── bootstrap@3.2.0

I try to build and run the the angular.js Benchmarks and everything looks working good.

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants