Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn.lock vs. package-lock.json #75

Closed
Trott opened this issue Apr 9, 2022 · 3 comments · Fixed by #76
Closed

yarn.lock vs. package-lock.json #75

Trott opened this issue Apr 9, 2022 · 3 comments · Fixed by #76

Comments

@Trott
Copy link
Contributor

Trott commented Apr 9, 2022

This has two competing lock files. Which one is the one to use? README seems to suggest that it's yarn.lock but it's 3 months older than the package-lock.json, so that suggests that maybe the package-lock.json is the one to use?

@mprobst
Copy link
Contributor

mprobst commented Apr 11, 2022

I think we're using npm ci, and thus package-lock.json.

https://github.com/angular/clang-format/blob/master/.github/workflows/node.js.yml

Care to send a PR to update the docs and delete yarn.lock?

Trott added a commit to Trott/clang-format that referenced this issue Apr 11, 2022
yarn.lock is older than package-lock.json.

Fixes: angular#75
@Trott
Copy link
Contributor Author

Trott commented Apr 11, 2022

Care to send a PR to update the docs and delete yarn.lock?

#76

No change to the docs. It turns out that the mentions of yarn were for end users who want to add clang-format to an existing project, not developers looking to install/debug the clang-format code itself.

mprobst pushed a commit that referenced this issue Apr 11, 2022
yarn.lock is older than package-lock.json.

Fixes: #75
@mprobst
Copy link
Contributor

mprobst commented Apr 11, 2022

Thanks for the fix @Trott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants