fix: check-clang-format not working on windows #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when someone runs the "check-clang-format" binary from the "clang-format" package on Windows, the script will always fail. This is because on Windows, the shebang cannot be read, and only the "PATHEXT" environment variable is respected. Therefore we can just explicitly declare that we want to run the "python" executable in the "PATH" environment variable. This ensures that the Python script can be launched properly on windows.
mprobst
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when someone runs the "check-clang-format"
binary from the "clang-format" package on Windows, the
script will always fail. This is because on Windows the
file shebang is not respected. Therefore we can just explicitly
declare that we want to run the "python" executable in the
"PATH" environment variable. This ensures that the Python
script can be launched properly on windows.