fix(bug): allow nullable parameterized types

fixes #56
angular · Aug 31, 2015 · ae4a79f · ae4a79f
1 parent 3281c13
commit ae4a79f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/google/javascript/cl2dts/DeclarationGenerator.java b/src/main/java/com/google/javascript/cl2dts/DeclarationGenerator.java
@@ -654,7 +654,7 @@ private void visitUnionType(UnionType ut) {
         public boolean apply(JSType input) {
           // Skip - TypeScript does not have explicit null or optional types.
           // Optional types must be handled at the declaration name (`foo?` syntax).
-          return !input.isNullable() && !input.isVoidType();
+          return !input.isNullType() && !input.isVoidType();
         }
       });
       if (alts.size() == 1) {

diff --git a/src/test/java/com/google/javascript/cl2dts/types.d.ts b/src/test/java/com/google/javascript/cl2dts/types.d.ts
@@ -5,7 +5,7 @@ declare namespace ಠ_ಠ.cl2dts_internal.types {
   var d : Object ;
   var e : any [] ;
   class Foo < T > {
-    genericMethod < V , W > (t : T , v : V ) : any ;
+    genericMethod < V , W > (t : T , v ? : V ) : any ;
     get ( ) : T ;
     set (t : T ) : void ;
   }

diff --git a/src/test/java/com/google/javascript/cl2dts/types.js b/src/test/java/com/google/javascript/cl2dts/types.js
@@ -29,7 +29,7 @@ types.Foo.prototype.set = function(t) { };
 
 /**
  * @param {T} t
- * @param {V} v
+ * @param {V=} v
  * @template V
  * @template W
  */