Skip to content

Commit

Permalink
fix(autocomplete): make template ViewChild query static: true (#15877)
Browse files Browse the repository at this point in the history
The `@ViewChild` query for TemplateRef here needs to be static because some code paths lead to the overlay being created before change detection has finished for this component. Notably, another component may trigger `focus` on the autocomplete-trigger.
  • Loading branch information
jelbourn committed Apr 22, 2019
1 parent b7f064b commit 388baa2
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/lib/autocomplete/autocomplete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ export class MatAutocomplete extends _MatAutocompleteMixinBase implements AfterC
get isOpen(): boolean { return this._isOpen && this.showPanel; }
_isOpen: boolean = false;

// The @ViewChild query for TemplateRef here needs to be static because some code paths
// lead to the overlay being created before change detection has finished for this component.
// Notably, another component may trigger `focus` on the autocomplete-trigger.

/** @docs-private */
@ViewChild(TemplateRef, {static: false}) template: TemplateRef<any>;
@ViewChild(TemplateRef, {static: true}) template: TemplateRef<any>;

/** Element for the panel containing the autocomplete options. */
@ViewChild('panel', {static: false}) panel: ElementRef;
Expand Down

0 comments on commit 388baa2

Please sign in to comment.