Skip to content

Commit

Permalink
ci: temporarily disable gesture config tests
Browse files Browse the repository at this point in the history
We need to temporarily disable the gesture tests in order to
land a PR in framework that makes Hammer support optional
(angular/angular#32203). Otherwise,
the Material/FW integration tests will fail because Material
modules haven't yet opted into Hammer.

Unfortunately, we cannot yet fix this properly by adding the
HammerModule to Material because Material is not using a
release that has HammerModule. Once the PR lands and Material
updates to a 9.0.0-next release, we can add the HammerModule
properly and turn these tests back on.
  • Loading branch information
kara committed Aug 20, 2019
1 parent c91f8ac commit 6204dc4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/material/core/gestures/gesture-config.spec.ts
Expand Up @@ -3,7 +3,12 @@ import {Component} from '@angular/core';
import {HAMMER_GESTURE_CONFIG} from '@angular/platform-browser';
import {GestureConfig, MAT_HAMMER_OPTIONS} from './gesture-config';

describe('GestureConfig', () => {
// TODO(kara): turn these tests back on when Material is using a release
// of Angular that contains the HammerModule. They need to be turned off
// for now in order to land https://github.com/angular/angular/pull/32203,
// which makes Hammer optional (so Material/FW integration tests don't start
// to fail).
xdescribe('GestureConfig', () => {
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [ButtonWithLongpressHander],
Expand Down

0 comments on commit 6204dc4

Please sign in to comment.