Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update firebase@4 to 5 to support win+node 10 #11735

Closed
amitport opened this issue Jun 10, 2018 · 4 comments
Closed

update firebase@4 to 5 to support win+node 10 #11735

amitport opened this issue Jun 10, 2018 · 4 comments

Comments

@amitport
Copy link
Contributor

Root package.json uses firebase@4 which transitively uses grpc@1.10.1 which fails to build on win+node 10. firebase@5 does not have this issue.

See also:
grpc/grpc#15403
#10401

@crisbeto
Copy link
Member

The current setup works on Windows and Node 8. I don't think we can bump to None 9 or 10 since Angular core is set to Node >=8.9.1 <9.0.0.

@amitport
Copy link
Contributor Author

amitport commented Jun 10, 2018

@crisbeto. OK. I've reverted to Node 8 LTS. In any case, in practice, only firebase@4 dependencies block the development of Material with Node@10. (I've manually overridden package-lock to require grpc@1.12.2 and it works fine)

@jelbourn
Copy link
Member

Closing this since it only affects node 10 which we haven't switched to yet.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants