Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to firebase@5 #768

Closed
amitport opened this issue Jun 10, 2018 · 4 comments
Closed

update to firebase@5 #768

amitport opened this issue Jun 10, 2018 · 4 comments

Comments

@amitport
Copy link
Contributor

amitport commented Jun 10, 2018

Bug Report

What is the expected behavior?

installing flex-layout for dev should work

What is the current behavior?

installing flex-layout for development fails on windows with node 10

Is there anything else we should know?

Root package.json uses firebase@4 which transitively uses grpc@1.10.1 which fails to build on win+node 10. firebase@5 does not have this issue.

See also:
grpc/grpc#15403
angular/components#10401
angular/components#11735

@CaerusKaru
Copy link
Member

Closing based on angular/components#11735 (comment)

@amitport
Copy link
Contributor Author

@CaerusKaru I don't really get it. Angular may not officially support Node.js@10, but it's not like it an esoteric end of life product. It's going to be LTS in October. You will need to update from firebase@4 soon enough and it should be an issue IMO (maybe not a very urgent one).

@CaerusKaru
Copy link
Member

We will upgrade if and when Material upgrades, since we just use their build system and configuration. When the material issue gets resolved, it will be resolved here. I don't see any point in having multiple issues for the same thing.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants