New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mat-chip-grid sometimes adds aria-required=false without no role #17397
Closed
Labels
Accessibility
This issue is related to accessibility (a11y)
G
This is is related to a Google internal issue
P2
The issue is important to a large percentage of users, with a workaround
Comments
Talked to @jelbourn about this bug offline |
jelbourn
added
Accessibility
This issue is related to accessibility (a11y)
G
This is is related to a Google internal issue
P2
The issue is important to a large percentage of users, with a workaround
labels
Oct 14, 2019
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Oct 16, 2019
Currently we always set `aria-required` `mat-chip-list`/`mat-chip-grid`, however it should only be set on form controls. If a chip list is empty we remove its role so we also have to clear the `aria-required`. Fixes angular#17397.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Oct 16, 2019
Currently we always set `aria-required` `mat-chip-list`/`mat-chip-grid`, however it should only be set on form controls. If a chip list is empty we remove its role so we also have to clear the `aria-required`. Fixes angular#17397.
mmalerba
pushed a commit
that referenced
this issue
Oct 17, 2019
Currently we always set `aria-required` `mat-chip-list`/`mat-chip-grid`, however it should only be set on form controls. If a chip list is empty we remove its role so we also have to clear the `aria-required`. Fixes #17397.
mmalerba
pushed a commit
that referenced
this issue
Oct 18, 2019
Currently we always set `aria-required` `mat-chip-list`/`mat-chip-grid`, however it should only be set on form controls. If a chip list is empty we remove its role so we also have to clear the `aria-required`. Fixes #17397.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Accessibility
This issue is related to accessibility (a11y)
G
This is is related to a Google internal issue
P2
The issue is important to a large percentage of users, with a workaround
Bug, feature request, or proposal:
Bug
What is the expected behavior?
aria-required should only be used when we have valid role attribute.
What is the current behavior?
I am using mdc-chips backed mat-chip-grid implementation. mat-chip-grid component is adding aria-required=false without a role when grid has rows.
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
This is a potential accessibility violation reported by axe. aria-required=false doesn't make sense for non form elements: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-required_attribute
The text was updated successfully, but these errors were encountered: