Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatStep.interacted is always false for last step #17974

Closed
LastDragon-ru opened this issue Dec 16, 2019 · 1 comment · Fixed by #17976
Closed

MatStep.interacted is always false for last step #17974

LastDragon-ru opened this issue Dec 16, 2019 · 1 comment · Fixed by #17976
Assignees
@crisbeto
Labels
area: material/stepper P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@LastDragon-ru
Copy link

LastDragon-ru commented Dec 16, 2019 •
edited

Reproduction

Steps to reproduce:

  1. Open https://stackblitz.com/edit/angular-dytmpt
  2. Click Next => Interacted = true
  3. Fill field
  4. Click Next
  5. Click Next => Interacted = false

This bug also prevents to update error state for controls on the last step.

Demo

Rx9WQFPrfu

Expected Behavior

On the last step interacted must be set to true after Next like on other steps.

Actual Behavior

On the last step interacted is always false

Environment

  • Angular: 8.2.14
  • CDK/Material: 8.2.3
  • Browser(s): chrome latest
  • Operating System (e.g. Windows, macOS, Ubuntu): win 10 x64
@crisbeto crisbeto self-assigned this Dec 16, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Dec 16, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 16, 2019
@crisbeto
fix(stepper): last step not being marked as interacted
1cec48c 
Fixes the last step in the stepper never being marked as `interacted`. Also fixes some weird logic where we were changing the step state inside `_anyControlsInvalidOrPending` which is a getter method.

Fixes angular#17974.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 16, 2019
@crisbeto
fix(stepper): last step not being marked as interacted
0b3d6a8 
Fixes the last step in the stepper never being marked as `interacted`. Also fixes some weird logic where we were changing the step state inside `_anyControlsInvalidOrPending` which is a getter method.

Fixes angular#17974.
@crisbeto crisbeto mentioned this issue Dec 16, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 6, 2020
@crisbeto
fix(material/stepper): last step not being marked as interacted
ea77330 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes angular#17974.
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto
fix(material/stepper): last step not being marked as interacted (#17976)
cd3d0e9 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes #17974.
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto @annieyw
fix(material/stepper): last step not being marked as interacted (#17976)
c0e2195 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes #17974.

(cherry picked from commit cd3d0e9)
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto @annieyw
fix(material/stepper): last step not being marked as interacted (#17976)
0d279b2 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes #17974.

(cherry picked from commit cd3d0e9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/stepper P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/stepper): last step not being marked as interacted crisbeto/material2
3 participants
@LastDragon-ru @crisbeto @andrewseguin