Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-form-field): fix server side rendering failures #18191

Merged

Conversation

devversion
Copy link
Member

Fixes server side rendering issues for the MDC-based form-field, and
adds the form-field to the universal-app for CI testing.

@devversion devversion added the target: patch This PR is targeted for the next patch release label Jan 16, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 16, 2020
…failures

Fixes server side rendering issues for the MDC-based form-field, and
adds the form-field to the universal-app for CI testing.
@devversion devversion force-pushed the build/add-form-field-mdc-to-prerender branch from e5890d7 to 851c0c9 Compare January 16, 2020 18:16
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 16, 2020
@jelbourn jelbourn merged commit 1ef30cb into angular:master Jan 22, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
…failures (angular#18191)

Fixes server side rendering issues for the MDC-based form-field, and
adds the form-field to the universal-app for CI testing.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants