Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required asterisk of form field labels are wrongly colored in accent color #18326

Closed
tarekis opened this issue Jan 29, 2020 · 2 comments
Closed
Labels
area: material/form-field Fixed in MDC material spec Issue related to the Material Design spec https://material.io/design/ P4 A relatively minor issue that is not relevant to core functions

Comments

@tarekis
Copy link

tarekis commented Jan 29, 2020

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Required asterisk of form field labels are colored in primary (as in the color that is used to color the label) color.

What is the current behavior?

Required asterisk of form field labels are colored in accent color.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-svwsjn (fork of offical template with required set on the input component)

What is the use-case or motivation for changing an existing behavior?

Fulfilling the (current) material design spec.

If required text is colored, that color should also be used for the asterisk

Taken from http://material.io/components/text-fields/#anatomy in the section Label text > Required text indicator at Wed, 29 Jan 2020 9:54:57 GMT, see screenshot for reference.

Workspace 1_446

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All permutations of every variable listed should be affected.

Confirmed with
Angular: 7.55
Material: 8.2.0; 8.2.3
OS: Ubuntu 18.04.3 LTS
Typescript: 3.5.3
Browsers: Chrome Version 79.0.3945.88 (Official Build) (64-bit)

Is there anything else we should know?

This has been this way since 2016, since the initial commit of the (then) responsible file for theming the asterisk: e0726e1#diff-002aa63d52575ed15761f1e16e547059R15

I suspect the material design spec was different back then.

This has been reported in a smaller scope previously, but not yet been fixed: #16826

tarekis added a commit to tarekis/components that referenced this issue Jan 29, 2020
Fixes a bug in the Angular Material `form-field` style
where the required-marker (asterisk) is specifically colored
in the accent color, contrary to what is defined in the current material design spec.

Fixes angular#18326
mmalerba pushed a commit that referenced this issue Feb 4, 2020
Fixes a bug in the Angular Material `form-field` style
where the required-marker (asterisk) is specifically colored
in the accent color, contrary to what is defined in the current material design spec.

Fixes #18326
@jelbourn jelbourn added has pr material spec Issue related to the Material Design spec https://material.io/design/ P4 A relatively minor issue that is not relevant to core functions labels Feb 6, 2020
@mmalerba
Copy link
Contributor

Dup of #16826

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/form-field Fixed in MDC material spec Issue related to the Material Design spec https://material.io/design/ P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants