Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mat-button-toggle default checked not wotking #18427

Closed
yuveliremil opened this issue Feb 7, 2020 · 1 comment · Fixed by #18442 or lingounet/testage#29
Closed

mat-button-toggle default checked not wotking #18427

yuveliremil opened this issue Feb 7, 2020 · 1 comment · Fixed by #18442 or lingounet/testage#29
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@yuveliremil
Copy link

mat-button-toggle default checked not wotking when :

"angularCompilerOptions": {
"enableIvy": true
}
@crisbeto crisbeto self-assigned this Feb 9, 2020
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Feb 9, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 9, 2020
@crisbeto
fix(button-toggle): static checked value not being picked up
96a9414 
Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes angular#18427.
@crisbeto crisbeto mentioned this issue Feb 9, 2020
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 1, 2020
@crisbeto
fix(button-toggle): static checked value not being picked up
dd80da5 
Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes angular#18427.
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto @mmalerba
fix(button-toggle): static checked value not being picked up
670fb54 
Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes #18427.
jelbourn pushed a commit that referenced this issue Apr 23, 2020
@crisbeto
fix(button-toggle): static checked value not being picked up (#18442)
7f7e0a1 
Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes #18427.
jelbourn pushed a commit that referenced this issue Apr 23, 2020
@crisbeto @jelbourn
fix(button-toggle): static checked value not being picked up (#18442)
1daada5 
Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes #18427.
soro-google pushed a commit to soro-google/components that referenced this issue Apr 24, 2020
@crisbeto @soro-google
fix(button-toggle): static checked value not being picked up (angular…
92c4a53 
…#18442)

Fixes the static checked value of a button toggle not having an effect in Ivy, because it ends up being assigned earlier than we expect. This is a side effect of the circular dependency between the toggle group and the toggle which should be cleaned up at some point, because it's not the first time it has caused issues with things going out of sync.

Fixes angular#18427.
@snyk-bot snyk-bot mentioned this issue May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @yuveliremil