Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-tab-group): mat-tab-group alignment not working when inside another #19035

Closed
wweitzel opened this issue Apr 9, 2020 · 1 comment · Fixed by #19037 or lingounet/testage#29
Closed

bug(mat-tab-group): mat-tab-group alignment not working when inside another #19035

wweitzel opened this issue Apr 9, 2020 · 1 comment · Fixed by #19037 or lingounet/testage#29
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@wweitzel
Copy link

wweitzel commented Apr 9, 2020

Reproduction

Here is a working stackblitz
https://stackblitz.com/edit/tabgroup-inside-tabgroup-alignment

In this example there is an outer mat-tab-group with two inner tab groups. The outer tab group has mat-align-tabs="center" and the first inner tab group has mat-align-tabs="start" but the first inner tab group is not aligned at the start. The second inner tab group with mat-align-tabs="end" is correct.

Expected Behavior

The first inner tab group should be left aligned since it is marked with mat-align-tabs="start"

Actual Behavior

The first inner tab group is aligned center.

Environment

See image

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):

image
@wweitzel wweitzel added the needs triage This issue needs to be triaged by the team label Apr 9, 2020
@wweitzel wweitzel changed the title bug([mat-tab-group]): [mat-tab-group alignment not working when inside another] bug(mat-tab-group): mat-tab-group alignment not working when inside another Apr 9, 2020
@crisbeto crisbeto self-assigned this Apr 10, 2020
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Apr 10, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 10, 2020
@crisbeto
fix(tabs): group alignment propagating to nested groups
f818bc4 
The selector that applies the alignment to the tab header was too broad which meant that it was applying to any nested tab groups.

Fixes angular#19035.
@crisbeto crisbeto mentioned this issue Apr 10, 2020
Merged
jelbourn pushed a commit that referenced this issue Apr 20, 2020
@crisbeto
fix(tabs): group alignment propagating to nested groups (#19037)
5224ac2 
The selector that applies the alignment to the tab header was too broad which meant that it was applying to any nested tab groups.

Fixes #19035.
jelbourn pushed a commit that referenced this issue Apr 20, 2020
@crisbeto @jelbourn
fix(tabs): group alignment propagating to nested groups (#19037)
59a5786 
The selector that applies the alignment to the tab header was too broad which meant that it was applying to any nested tab groups.

Fixes #19035.

(cherry picked from commit 5224ac2)
soro-google pushed a commit to soro-google/components that referenced this issue Apr 24, 2020
@crisbeto @soro-google
fix(tabs): group alignment propagating to nested groups (angular#19037)
3916b63 
The selector that applies the alignment to the tab header was too broad which meant that it was applying to any nested tab groups.

Fixes angular#19035.
@snyk-bot snyk-bot mentioned this issue May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @wweitzel