Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fr(Checkbox): Allow aria-describedby on checkboxes #19477

Closed
mfairchild365 opened this issue May 28, 2020 · 1 comment · Fixed by #19495
Closed

fr(Checkbox): Allow aria-describedby on checkboxes #19477

mfairchild365 opened this issue May 28, 2020 · 1 comment · Fixed by #19495
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mfairchild365
Copy link

Feature Description

There are situations where aria-describedby may be needed on checkboxes.

Use Case

These situations are similar to why the attribute is allowed on radio buttons.
@mfairchild365 mfairchild365 added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels May 28, 2020
@mmalerba mmalerba added Accessibility This issue is related to accessibility (a11y) area: material/checkbox P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels May 28, 2020
@crisbeto crisbeto self-assigned this May 31, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue May 31, 2020
@crisbeto
fix(checkbox): pass aria-describedby through to input
f2bfa44 
Passes the `aria-describedby` attribute value through to the underlying `input` element.

Fixes angular#19477.
@crisbeto crisbeto mentioned this issue May 31, 2020
Merged
jelbourn pushed a commit that referenced this issue Jun 5, 2020
@crisbeto
fix(checkbox): pass aria-describedby through to input (#19495)
e1d85d2 
Passes the `aria-describedby` attribute value through to the underlying `input` element.

Fixes #19477.
jelbourn pushed a commit that referenced this issue Jun 5, 2020
@crisbeto @jelbourn
fix(checkbox): pass aria-describedby through to input (#19495)
7e38d46 
Passes the `aria-describedby` attribute value through to the underlying `input` element.

Fixes #19477.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkbox): pass aria-describedby through to input crisbeto/material2
3 participants
@mfairchild365 @crisbeto @mmalerba