Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): range input separator not hidden in high contrast mode #19706

Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix(datepicker): range input separator not hidden in high contrast mode #19706

merged 1 commit into from
Jun 29, 2020

Conversation

crisbeto
Copy link
Member

We use color: transparent to hide the separator text, but browsers will still show it in high contrast mode. These changes use opacity instead.

@crisbeto
fix(datepicker): range input separator not hidden in high contrast mode
361c99a 
We use `color: transparent` to hide the separator text, but browsers will still show it in high contrast mode. These changes use `opacity` instead.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 20, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner June 20, 2020 12:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2020
mmalerba
mmalerba approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 23, 2020
@jelbourn jelbourn merged commit 9af441d into angular:master Jun 29, 2020
jelbourn pushed a commit that referenced this pull request Jun 29, 2020
@crisbeto @jelbourn
fix(datepicker): range input separator not hidden in high contrast mo…
2894a71 
…de (#19706)

We use `color: transparent` to hide the separator text, but browsers will still show it in high contrast mode. These changes use `opacity` instead.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot