Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): don't close when clicking inside custom origin #19784

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix(autocomplete): don't close when clicking inside custom origin #19784

merged 1 commit into from
Jun 30, 2020

Conversation

crisbeto
Copy link
Member

We allow the consumer to set an alternate element that an autocomplete will be attached to, but our logic for closing when the user clicks outside the autocomplete didn't account for it which meant that it was being treated as not being part of the autocomplete.

Fixes #19771.

@crisbeto
fix(autocomplete): don't close when clicking inside custom origin
e2ec506 
We allow the consumer to set an alternate element that an autocomplete will be attached to, but our logic for closing when the user clicks outside the autocomplete didn't account for it which meant that it was being treated as not being part of the autocomplete.

Fixes angular#19771.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 27, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 27, 2020
jelbourn
jelbourn approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 29, 2020
@jelbourn jelbourn merged commit 1319c0a into angular:master Jun 30, 2020
jelbourn pushed a commit that referenced this pull request Jun 30, 2020
@crisbeto @jelbourn
fix(autocomplete): don't close when clicking inside custom origin (#1…
c4fe609 
…9784)

We allow the consumer to set an alternate element that an autocomplete will be attached to, but our logic for closing when the user clicks outside the autocomplete didn't account for it which meant that it was being treated as not being part of the autocomplete.

Fixes #19771.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(autocomplete): Clicks within custom wrapper/origin should not close the panel
3 participants
@crisbeto @jelbourn @googlebot