fix(material/progress-spinner): Progress spinner animation fails for floating point diameter values #20192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…floating point diameter values Fixes a bug in the Angular Material `progress-spinner` component where spinner animations do not work for custom diameters with float point values. This is because the animation-name CSS style on the spinner circle includes an unsupported period ‘.’ character when the diameter is a float point number. An underscore can be substituted instead of a period to fix this. Fixes angular#20158
AlexLangdon
force-pushed
the
float-spinner-diameter-fix
branch
from
f7c636f
to
dd2b0d6
Compare
crisbeto
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Aug 19, 2020
…floating point diameter values (#20192) Fixes a bug in the Angular Material `progress-spinner` component where spinner animations do not work for custom diameters with float point values. This is because the animation-name CSS style on the spinner circle includes an unsupported period ‘.’ character when the diameter is a float point number. An underscore can be substituted instead of a period to fix this. Fixes #20158 (cherry picked from commit 2c47b06)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spinner diameter is used in the
animation-nameCSS property for the indeterminate spinnercircleelement. If the diameter is a floating point value the animation name will include a period ‘.’ character e.g.animation-name-90.6. Period characters are not supported for the animation-name property - see https://developer.mozilla.org/en-US/docs/Web/CSS/animation-name.Replacing the period character in the diameter string with an underscore fixes this issue e.g.
animation-name-90_6Fixes #20158