fix(material/progress-spinner): spinner circle expands beyond the specified diameter #20289
+198
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cified diameter Fixes a bug in the Angular Material ‘progress-spinner’ component where progress-spinners with a stroke width greater than 10 begin to expand outside its specified diameter and parent element. This is because the spinner radius calculation uses a constant stroke width of 10 instead of the current stroke width. This fix also allows values smaller than 11 and floating point values to be used for the spinner custom diameters. Fixes angular#20159 Fixes angular#20158 Fixes angular#19469
googlebot
added
the
cla: yes
andrewseguin
removed
the
cla: yes
|
Closing since this fix is for the legacy mat-progress-spinner which has been superseded by the MDC-based one. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
BASE_STROKE_WIDTHto calculate the spinner circle radius is causing issues, such as the progress spinner circle expanding and overlapping adjacent elements for stroke widths greater than 10.The proposed solution is to use the current stroke width instead of the
BASE_STROKE_WIDTHconstant for calculating the spinner radius.This will ensure that the spinner
circleelement always has the specified diameter and is within the parentmat-progress-spinnerelement.Although this change is primarily intended to fix #20159, it will also result in fixing #19469 and #20158 as a consequence.
Also worth noting that fixing #20159 will correct the way the spinner component appears, so may lead to braking screenshot tests that depend on the incorrect behaviour.
Before change
After change
This PR supercedes PR #20062
Fixes #20159
Fixes #20158
Fixes #19469