New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material-experimental/mdc-autocomplete): implement MDC-based mat-autocomplete #20247
Conversation
export declare const MAT_AUTOCOMPLETE_VALUE_ACCESSOR: any; | ||
|
||
export declare class MatAutocomplete extends _MatAutocompleteMixinBase implements AfterContentInit, CanDisableRipple, OnDestroy { | ||
export declare abstract class _MatAutocompleteBase extends _MatAutocompleteMixinBase implements AfterContentInit, CanDisableRipple, OnDestroy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API differences here come from the fact that I moved all the logic into a base class, but everything should be backwards-compatible.
50adb1c
to
10382e6
Compare
10382e6
to
e9fe172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple comments on comments
…-autocomplete * Moves all of the autocomplete logic into base classes so that it can be reused between the standard and MDC components. * Re-implements `mat-autocomplete` using the logic from the existing one and the styling from MDC. The MDC-based autocomplete behaves identically to the existing one, with the only minor difference being that MDC one fixes a long-standing issue where we expect a hardcoded height for each of the options. It was easier to fix the bug and add logic to support arbitrary option heights than to add more logic to account for MDC's styles.
e9fe172
to
da4eb2d
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
mat-autocomplete
using the logic from the existing one and the styling from MDC.The MDC-based autocomplete behaves identically to the existing one, with the only minor difference being that MDC one fixes a long-standing issue where we expect a hardcoded height for each of the options. It was easier to fix the bug and add logic to support arbitrary option heights than to add more logic to account for MDC's styles.
Note: I will make a follow-up PR that adds test harnesses for the new module. I didn't add them here, because the PR is fairly large as it is.