feat(material-experimental/mdc-autocomplete): implement MDC-based mat-autocomplete #20247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Aug 8, 2020
| export declare const MAT_AUTOCOMPLETE_VALUE_ACCESSOR: any; | ||
|
|
||
| export declare class MatAutocomplete extends _MatAutocompleteMixinBase implements AfterContentInit, CanDisableRipple, OnDestroy { | ||
| export declare abstract class _MatAutocompleteBase extends _MatAutocompleteMixinBase implements AfterContentInit, CanDisableRipple, OnDestroy { |
There was a problem hiding this comment.
The API differences here come from the fact that I moved all the logic into a base class, but everything should be backwards-compatible.
crisbeto
force-pushed
the
mdc-autocomplete
branch
2 times, most recently
from
50adb1c to
10382e6
Compare
crisbeto
requested review from
devversion,
jelbourn,
mmalerba and
a team
as code owners
crisbeto
added
P2
crisbeto
force-pushed
the
mdc-autocomplete
branch
from
10382e6 to
e9fe172
Compare
jelbourn
approved these changes
Aug 10, 2020
…-autocomplete * Moves all of the autocomplete logic into base classes so that it can be reused between the standard and MDC components. * Re-implements `mat-autocomplete` using the logic from the existing one and the styling from MDC. The MDC-based autocomplete behaves identically to the existing one, with the only minor difference being that MDC one fixes a long-standing issue where we expect a hardcoded height for each of the options. It was easier to fix the bug and add logic to support arbitrary option heights than to add more logic to account for MDC's styles.
crisbeto
force-pushed
the
mdc-autocomplete
branch
from
e9fe172 to
da4eb2d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mat-autocompleteusing the logic from the existing one and the styling from MDC.The MDC-based autocomplete behaves identically to the existing one, with the only minor difference being that MDC one fixes a long-standing issue where we expect a hardcoded height for each of the options. It was easier to fix the bug and add logic to support arbitrary option heights than to add more logic to account for MDC's styles.
Note: I will make a follow-up PR that adds test harnesses for the new module. I didn't add them here, because the PR is fairly large as it is.