Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): support readonly collections in inputs #20292

Merged
merged 1 commit into from Aug 20, 2020

Conversation

rafaelss95
Copy link
Contributor

Currently if I try to pass immutable collections with strictTemplates I get an error.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 13, 2020
@rafaelss95 rafaelss95 force-pushed the refactor/chips branch 2 times, most recently from 02faa18 to 183fa72 Compare August 13, 2020 03:47
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some build errors. Also I suspect that this may be difficult to land, based on the experience from doing the same for the mat-tree (#17825).

@rafaelss95
Copy link
Contributor Author

Looks like there are some build errors. Also I suspect that this may be difficult to land, based on the experience from doing the same for the mat-tree (#17825).

The errors are gone now. About #17825 I guess here is a little different from that because here I just relaxed the input type to accept immutable collections as well, so I imagine that no apps should break.

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Aug 14, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems reasonable, but like Kristiyan said, it may be hard to land. I think we can try presubmitting it and if there's a lot of failures we might have to make it target: major

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2020
@jelbourn jelbourn added the P4 A relatively minor issue that is not relevant to core functions label Aug 17, 2020
@rafaelss95
Copy link
Contributor Author

LGTM. This seems reasonable, but like Kristiyan said, it may be hard to land. I think we can try presubmitting it and if there's a lot of failures we might have to make it target: major

No problem, let me know if there's something that I need to do after you presubmit it.

@wagnermaciel wagnermaciel merged commit 134cbf3 into angular:master Aug 20, 2020
@rafaelss95 rafaelss95 deleted the refactor/chips branch August 20, 2020 02:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants