New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chips): support readonly collections in inputs #20292
Conversation
02faa18
to
183fa72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some build errors. Also I suspect that this may be difficult to land, based on the experience from doing the same for the mat-tree
(#17825).
183fa72
to
f010a04
Compare
f010a04
to
3ef1031
Compare
The errors are gone now. About #17825 I guess here is a little different from that because here I just relaxed the input type to accept immutable collections as well, so I imagine that no apps should break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This seems reasonable, but like Kristiyan said, it may be hard to land. I think we can try presubmitting it and if there's a lot of failures we might have to make it target: major
No problem, let me know if there's something that I need to do after you presubmit it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently if I try to pass immutable collections with
strictTemplates
I get an error.