fix(tree): allow readonly arrays in getChildren return type #17825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
Turns out that this is a breaking change; anywhere this value is assigned into something else the types don't match now. It has ~60 failing build targets across a bunch of projects |
jelbourn
added
target: major
crisbeto
force-pushed
the
17824/tree-get-children-readonly
branch
2 times, most recently
from
caa8111
to
a793288
Compare
Fixes not being allowed to return a `ReadonlyArray` from a `getChildren` function. Also pulls the definition for the `getChildren` function into a separate type so we don't have to maintain it in 4 different places. Fixes angular#17824.
crisbeto
force-pushed
the
17824/tree-get-children-readonly
branch
from
a793288
to
f7f3dac
Compare
|
What is the status of this PR? This PR didn't land in neither v10, v11 nor v12 although it is 1.5 years old. A similar PR for chips was merged within a week |
andrewseguin
removed
the
cla: yes
andrewseguin
removed
the
P3
josephperrott
added
the
action: cleanup
|
Closing since the tree is in the process of being reworked. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being allowed to return a
ReadonlyArrayfrom agetChildrenfunction. Also pulls the definition for thegetChildrenfunction into a separate type so we don't have to maintain it in 4 different places.Fixes #17824.