Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(CdkTable): 10.2 has a breaking change wrt _VIEW_REPEATER_STRATEGY #20601

Closed
jpzwarte opened this issue Sep 18, 2020 · 1 comment · Fixed by #20604
Closed

bug(CdkTable): 10.2 has a breaking change wrt _VIEW_REPEATER_STRATEGY #20601

jpzwarte opened this issue Sep 18, 2020 · 1 comment · Fixed by #20604
Assignees
@crisbeto
Labels
area: cdk/table P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression

Comments

@jpzwarte
Copy link
Contributor

Our design system is still on Angular 9 (until angular 11 is released, then we can move to 10).

We cannot support CDK 10.2.* because it requires us to add { provide: _VIEW_REPEATER_STRATEGY, useClass: _DisposeViewRepeaterStrategy } to our table component (which extends CdkTable). However, this is new code in 10.2 and thus we cannot use it.

The result is a table with no rows if you don't provide the repeater. See https://github.com/angular/components/blob/10.2.x/src/cdk/table/table.ts#L560 for the reason there are no rows if there is no repeater provided.

cc @jelbourn
@jpzwarte jpzwarte added the needs triage This issue needs to be triaged by the team label Sep 18, 2020
@crisbeto crisbeto self-assigned this Sep 18, 2020
@crisbeto crisbeto added area: cdk/table has pr P2 The issue is important to a large percentage of users, with a workaround and removed needs triage This issue needs to be triaged by the team labels Sep 18, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 18, 2020
@crisbeto
fix(cdk/table): add fallback code if view repeater isn't provided
c60f993 
The `_viewRepeater` parameter is currently optional due to our breaking change policy,
however if it isn't provided, the table is basically a no-op. These changes add the old
rendering logic while we have to support both cases.

Fixes angular#20601.
@crisbeto crisbeto added the regression This issue is related to a regression label Sep 18, 2020
@crisbeto crisbeto mentioned this issue Sep 18, 2020
Merged
annieyw pushed a commit that referenced this issue Sep 23, 2020
@crisbeto
fix(cdk/table): add fallback code if view repeater isn't provided (#2…
54c66bc 
…0604)

The `_viewRepeater` parameter is currently optional due to our breaking change policy,
however if it isn't provided, the table is basically a no-op. These changes add the old
rendering logic while we have to support both cases.

Fixes #20601.
annieyw pushed a commit that referenced this issue Sep 23, 2020
@crisbeto @annieyw
fix(cdk/table): add fallback code if view repeater isn't provided (#2…
bfb7e57 
…0604)

The `_viewRepeater` parameter is currently optional due to our breaking change policy,
however if it isn't provided, the table is basically a no-op. These changes add the old
rendering logic while we have to support both cases.

Fixes #20601.

(cherry picked from commit 54c66bc)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Sep 24, 2020
@crisbeto @wagnermaciel
fix(cdk/table): add fallback code if view repeater isn't provided (an…
f2da1b2 
…gular#20604)

The `_viewRepeater` parameter is currently optional due to our breaking change policy,
however if it isn't provided, the table is basically a no-op. These changes add the old
rendering logic while we have to support both cases.

Fixes angular#20601.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(cdk/table): add fallback code if view repeater isn't provided (an…
3fa95aa 
…gular#20604)

The `_viewRepeater` parameter is currently optional due to our breaking change policy,
however if it isn't provided, the table is basically a no-op. These changes add the old
rendering logic while we have to support both cases.

Fixes angular#20601.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: cdk/table P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk/table): add fallback code if view repeater isn't provided crisbeto/material2
2 participants
@jpzwarte @crisbeto