Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MatNavListItemHarness): getText() needs to exclude icons #20812

Closed
mikzat opened this issue Oct 15, 2020 · 1 comment · Fixed by #20845
Closed

bug(MatNavListItemHarness): getText() needs to exclude icons #20812

mikzat opened this issue Oct 15, 2020 · 1 comment · Fixed by #20845
Assignees
@crisbeto
Labels
G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mikzat
Copy link

mikzat commented Oct 15, 2020

MatNavListItemHarness function getText() is including text for icons inside the mat-list-item:

<a mat-list-item>
  <mat-icon matListIcon>help</mat-icon>
  <p>Help</p>
</a>

Using getText() for the above case currently outputs 'helpHelp'. There should be some mechanism of getting the text without the icon.
@mikzat mikzat added the needs triage This issue needs to be triaged by the team label Oct 15, 2020
@jelbourn jelbourn added G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent needs: discussion Further discussion with the team is needed before proceeding and removed needs triage This issue needs to be triaged by the team labels Oct 15, 2020
@crisbeto crisbeto self-assigned this Oct 16, 2020
@crisbeto crisbeto added has pr needs: discussion Further discussion with the team is needed before proceeding and removed needs: discussion Further discussion with the team is needed before proceeding has pr labels Oct 16, 2020
@crisbeto crisbeto assigned crisbeto and unassigned crisbeto Oct 16, 2020
@crisbeto crisbeto removed the needs: discussion Further discussion with the team is needed before proceeding label Oct 19, 2020
@crisbeto crisbeto mentioned this issue Oct 19, 2020
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2020
@crisbeto
fix(material/list): exclude icons from harness getText result
5ebe26c 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes angular#20812.
@crisbeto crisbeto mentioned this issue Oct 21, 2020
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2020
@crisbeto
fix(material/list): exclude icons from harness getText result
07556b4 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes angular#20812.
wagnermaciel pushed a commit that referenced this issue Oct 28, 2020
@crisbeto
fix(material/list): exclude icons from harness getText result (#20845)
dfdd422 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.
wagnermaciel pushed a commit that referenced this issue Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
aec12b6 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
wagnermaciel pushed a commit that referenced this issue Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
8638456 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (angula…
b85ebc3 
…r#20845)

Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes angular#20812.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/list): exclude icons from harness getText result crisbeto/material2
3 participants
@jelbourn @crisbeto @mikzat