Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(material/menu): Disable Icons In Menu #20947

Closed
Joe-Kang opened this issue Oct 31, 2020 · 1 comment · Fixed by #20948
Closed

bug(material/menu): Disable Icons In Menu #20947

Joe-Kang opened this issue Oct 31, 2020 · 1 comment · Fixed by #20948
Assignees
@crisbeto
Labels
area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Joe-Kang
Copy link

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/angular/qvrxrqkalqq?file=src/app/menu-icons-example.ts

Steps to reproduce:

  1. Make mat-menu-item button disabled
  2. Add a icon in the disabled button

Expected Behavior

What behavior were you expecting to see?
The icon becoming disabled.

Actual Behavior

What behavior did you actually see?
The icon looks active, as if I can still click on the menu item.

Environment

  • Angular: Latest
  • CDK/Material: Latest
  • Browser(s): Any
  • Operating System (e.g. Windows, macOS, Ubuntu): Any
@Joe-Kang Joe-Kang added the needs triage This issue needs to be triaged by the team label Oct 31, 2020
@crisbeto crisbeto self-assigned this Nov 1, 2020
@crisbeto crisbeto added area: material/menu has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Nov 1, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 1, 2020
@crisbeto
fix(material/menu): icons in menu not inheriting disabled color
e42dcc3 
Fixes that the icons inside a disabled menu item still have their non-disabled color.

Fixes angular#20947.
@crisbeto crisbeto mentioned this issue Nov 1, 2020
Merged
annieyw pushed a commit that referenced this issue Nov 24, 2020
@crisbeto
fix(material/menu): icons in menu not inheriting disabled color (#20948)
832d2a0 
Fixes that the icons inside a disabled menu item still have their non-disabled color.

Fixes #20947.
annieyw pushed a commit that referenced this issue Nov 24, 2020
@crisbeto @annieyw
fix(material/menu): icons in menu not inheriting disabled color (#20948)
e629d65 
Fixes that the icons inside a disabled menu item still have their non-disabled color.

Fixes #20947.

(cherry picked from commit 832d2a0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/menu): icons in menu not inheriting disabled color (angu…
04022bd 
…lar#20948)

Fixes that the icons inside a disabled menu item still have their non-disabled color.

Fixes angular#20947.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/menu): icons in menu not inheriting disabled color crisbeto/material2
2 participants
@crisbeto @Joe-Kang