Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MatChip): Ripples not disabled when NoopAnimationsModule is used #20981

Closed
tomasdev opened this issue Nov 6, 2020 · 1 comment · Fixed by #20982
Closed

bug(MatChip): Ripples not disabled when NoopAnimationsModule is used #20981

tomasdev opened this issue Nov 6, 2020 · 1 comment · Fixed by #20982
Assignees
@crisbeto
Labels
area: material/chips P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@tomasdev
Copy link

tomasdev commented Nov 6, 2020

Reproduction

See demo: https://components-issue-rcwnj1.stackblitz.io

Steps to reproduce:

  1. Use NoopAnimationsModule
  2. Observe button when clicked: no ripple
  3. Observe chip when clicked: still has ripple

Expected Behavior

Chip click does not have ripple when using NoopAnimationsModule

Actual Behavior

Chip click still animates ripple when using NoopAnimationsModule

Environment

  • Angular: 10
  • CDK/Material: any?
  • Browser(s): any
  • Operating System (e.g. Windows, macOS, Ubuntu): any
@tomasdev tomasdev added the needs triage This issue needs to be triaged by the team label Nov 6, 2020
@crisbeto crisbeto self-assigned this Nov 6, 2020
@crisbeto crisbeto added area: material/chips has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Nov 6, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 6, 2020
@crisbeto
fix(material/chips): ripple not disabled when animations are disabled
247d917 
Fixes that the chip fires ripples even if all animations are disabled.

Fixes angular#20981.
@crisbeto crisbeto mentioned this issue Nov 6, 2020
Merged
wagnermaciel pushed a commit that referenced this issue Nov 17, 2020
@crisbeto
fix(material/chips): ripple not disabled when animations are disabled (…
41ac773 
…#20982)

Fixes that the chip fires ripples even if all animations are disabled.

Fixes #20981.
wagnermaciel pushed a commit that referenced this issue Nov 17, 2020
@crisbeto @wagnermaciel
fix(material/chips): ripple not disabled when animations are disabled (…
42acf11 
…#20982)

Fixes that the chip fires ripples even if all animations are disabled.

Fixes #20981.

(cherry picked from commit 41ac773)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/chips): ripple not disabled when animations are disabled (…
7ac63a9 
…angular#20982)

Fixes that the chip fires ripples even if all animations are disabled.

Fixes angular#20981.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/chips P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/chips): ripple not disabled when animations are disabled crisbeto/material2
2 participants
@tomasdev @crisbeto